Conversation
Codecov Report
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
approved these changes
Aug 18, 2023
b03ad73 to
7a32e44
Compare
alessandromazza98
pushed a commit
to alessandromazza98/reth
that referenced
this pull request
Aug 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
metrics-processmetrics doesn't have areth_prefix.Root cause
metrics-processdependency was updated to latest version in #3988, and with it themetricsdependency made a bumpreth/Cargo.lock
Line 3966 in efab153
while other crates depending on
metricscontinued to use older versionreth/Cargo.lock
Line 5692 in efab153
The problem with this is that
metrics-macrouses the globalRECORDERvariable which we configure using older version ofmetricscratereth/bin/reth/src/prometheus_exporter.rs
Lines 34 to 38 in efab153
metrics-processuses) doesn't see it.Solution
Use the same version of
metricsdependency everywhere, so bump it to latest0.21.1. The tricky part is this change metrics-rs/metrics#358, which required defining themetricsdependency on the crate level (https://doc.rust-lang.org/reference/paths.html#path-qualifiers).