Skip to content

feat: enable size-limited file logs by default#4192

Merged
mattsse merged 7 commits intomainfrom
onbjerg/max-log
Sep 18, 2023
Merged

feat: enable size-limited file logs by default#4192
mattsse merged 7 commits intomainfrom
onbjerg/max-log

Conversation

@onbjerg
Copy link
Collaborator

@onbjerg onbjerg commented Aug 14, 2023

Replaces --log.persistent with --log.max-size (default 200MB) and --log.max-files (default 5).

If --log.max-files is greater than 0, then files of maximum --log.max-size will be stored on a rotating basis.

Closes #4095

@onbjerg onbjerg added C-enhancement New feature or request M-changelog This change should be included in the changelog A-cli Related to the reth CLI S-breaking This PR includes a breaking change labels Aug 14, 2023
@onbjerg onbjerg requested a review from gakonst as a code owner August 14, 2023 13:20
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #4192 (cc3e8ae) into main (aeb37aa) will increase coverage by 0.02%.
The diff coverage is 93.10%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/cli/mod.rs 74.60% <85.71%> (+3.17%) ⬆️
crates/tracing/src/lib.rs 89.55% <100.00%> (+37.70%) ⬆️

... and 19 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.98% <0.00%> (+<0.01%) ⬆️
unit-tests 63.19% <93.10%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 31.95% <93.10%> (+0.58%) ⬆️
blockchain tree 82.86% <ø> (-0.74%) ⬇️
pipeline 88.54% <ø> (ø)
storage (db) 73.37% <ø> (-0.08%) ⬇️
trie 94.70% <ø> (-0.04%) ⬇️
txpool 49.89% <ø> (+0.46%) ⬆️
networking 77.24% <ø> (+0.06%) ⬆️
rpc 57.35% <ø> (-0.01%) ⬇️
consensus 62.18% <ø> (-0.25%) ⬇️
revm 19.66% <ø> (ø)
payload builder 9.06% <ø> (ø)
primitives 86.35% <ø> (-0.10%) ⬇️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable,

do we still want this @onbjerg ?

@onbjerg
Copy link
Collaborator Author

onbjerg commented Sep 18, 2023

@mattsse yes, however the deny check is failing and I'm not too sure what to do here, wdyt?

@mattsse mattsse enabled auto-merge September 18, 2023 13:56
@mattsse mattsse added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit 6658920 Sep 18, 2023
@mattsse mattsse deleted the onbjerg/max-log branch September 18, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Related to the reth CLI C-enhancement New feature or request M-changelog This change should be included in the changelog S-breaking This PR includes a breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Persist and rotate logs by default

2 participants