Skip to content

fix: serde rename revertReason#4002

Merged
mattsse merged 1 commit intomainfrom
matt/fix-revert-reasn
Jul 31, 2023
Merged

fix: serde rename revertReason#4002
mattsse merged 1 commit intomainfrom
matt/fix-revert-reasn

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 31, 2023

fixes wrong field name:

 "revert_reason": "TRANSFER_FROM_FAILED",

@mattsse mattsse requested a review from Rjected as a code owner July 31, 2023 14:51
@mattsse mattsse added M-changelog This change should be included in the changelog A-rpc Related to the RPC implementation labels Jul 31, 2023
@mattsse mattsse requested a review from onbjerg July 31, 2023 14:52
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #4002 (c8fb4c9) into main (c0544ed) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc-types/src/eth/trace/geth/call.rs 100.00% <ø> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.26% <ø> (ø)
unit-tests 64.20% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.76% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 90.03% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.40% <ø> (-0.63%) ⬇️
networking 77.53% <ø> (+0.03%) ⬆️
rpc 58.53% <ø> (+0.02%) ⬆️
consensus 63.51% <ø> (ø)
revm 33.10% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 88.05% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit dee14c7 Jul 31, 2023
@mattsse mattsse deleted the matt/fix-revert-reasn branch July 31, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation M-changelog This change should be included in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants