Skip to content

chore(deps): make jsonrpsee types a feature#3999

Merged
onbjerg merged 1 commit intomainfrom
matt/make-jsonrpsee-types-feature
Jul 31, 2023
Merged

chore(deps): make jsonrpsee types a feature#3999
onbjerg merged 1 commit intomainfrom
matt/make-jsonrpsee-types-feature

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 31, 2023

ref #3964

I'd like to keep these conversion utils, but feature gate them

@mattsse mattsse requested a review from Rjected as a code owner July 31, 2023 11:48
@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 31, 2023
@mattsse mattsse force-pushed the matt/make-jsonrpsee-types-feature branch from 7bfbe13 to e6d13ac Compare July 31, 2023 11:56
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #3999 (e6d13ac) into main (73652ed) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 28.57%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc-types/src/eth/engine/forkchoice.rs 34.09% <ø> (ø)
crates/rpc/rpc-types/src/eth/filter.rs 74.68% <0.00%> (ø)
crates/rpc/rpc-types/src/eth/block.rs 39.08% <100.00%> (+0.23%) ⬆️

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.35% <0.00%> (+<0.01%) ⬆️
unit-tests 64.31% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.67% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.40% <ø> (ø)
networking 77.65% <ø> (-0.02%) ⬇️
rpc 58.52% <28.57%> (+0.02%) ⬆️
consensus 63.51% <ø> (ø)
revm 33.08% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 87.91% <ø> (-0.03%) ⬇️

@onbjerg onbjerg added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit 922d35d Jul 31, 2023
@onbjerg onbjerg deleted the matt/make-jsonrpsee-types-feature branch July 31, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants