Skip to content

docs: add additional documentation to TxType#3996

Merged
mattsse merged 2 commits intomainfrom
docs/tx-type
Jul 31, 2023
Merged

docs: add additional documentation to TxType#3996
mattsse merged 2 commits intomainfrom
docs/tx-type

Conversation

@joshieDo
Copy link
Collaborator

ref #3953 (comment)

So in the future we do not forget that adding a new type is a breaking change.

@joshieDo joshieDo requested review from mattsse and rkrasiuk July 31, 2023 10:07
@joshieDo joshieDo requested a review from gakonst as a code owner July 31, 2023 10:07
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #3996 (b864a5e) into main (f41386d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/transaction/tx_type.rs 69.69% <ø> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.33% <ø> (-0.01%) ⬇️
unit-tests 64.33% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.67% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.00% <ø> (ø)
networking 77.64% <ø> (-0.02%) ⬇️
rpc 58.47% <ø> (ø)
consensus 63.51% <ø> (ø)
revm 33.08% <ø> (ø)
payload builder 6.58% <ø> (ø)
primitives 87.91% <ø> (ø)

Copy link
Contributor

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, ty

@rkrasiuk rkrasiuk added C-docs An addition or correction to our documentation A-db Related to the database labels Jul 31, 2023
@mattsse mattsse enabled auto-merge July 31, 2023 11:27
@mattsse mattsse added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit ed3d736 Jul 31, 2023
@mattsse mattsse deleted the docs/tx-type branch July 31, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-db Related to the database C-docs An addition or correction to our documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants