Skip to content

feat(txpool) - add flag for local tx propagation#3977

Merged
mattsse merged 2 commits intoparadigmxyz:mainfrom
0xprames:reth-issue-3966
Jul 28, 2023
Merged

feat(txpool) - add flag for local tx propagation#3977
mattsse merged 2 commits intoparadigmxyz:mainfrom
0xprames:reth-issue-3966

Conversation

@0xprames
Copy link
Contributor

@0xprames 0xprames commented Jul 28, 2023

should close #3966

@0xprames 0xprames requested a review from mattsse as a code owner July 28, 2023 04:13
@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #3977 (143de80) into main (d8677b4) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 143de80 differs from pull request most recent head d3f4137. Consider uploading reports for the commit d3f4137 to get more accurate results

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/validate/eth.rs 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.32% <0.00%> (-0.03%) ⬇️
unit-tests 64.22% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.21% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.40% <0.00%> (-0.15%) ⬇️
networking 77.62% <ø> (-0.04%) ⬇️
rpc 58.51% <ø> (ø)
consensus 64.46% <ø> (ø)
revm 33.08% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.81% <ø> (-0.01%) ⬇️

mattsse
mattsse requested changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

this is functionally complete, only have a few nits

crates/transaction-pool/src/validate/eth.rs Outdated
Copy link
Collaborator

@mattsse mattsse Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a bit more context:

basically if set to true (default), all locally received transactions (via RPC for example) will be propagated over the network

Copy link
Contributor Author

@0xprames 0xprames Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, added a bit more context

@mattsse mattsse added A-rpc Related to the RPC implementation A-tx-pool Related to the transaction mempool A-networking Related to networking in general labels Jul 28, 2023
@0xprames 0xprames requested a review from mattsse July 28, 2023 14:10
mattsse
mattsse approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, tysm

@mattsse mattsse added this pull request to the merge queue Jul 28, 2023
Merged via the queue into paradigmxyz:main with commit 15bb1c9 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes

Assignees

No one assigned

Labels

A-networking Related to networking in general A-rpc Related to the RPC implementation A-tx-pool Related to the transaction mempool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding a config value for passing local transactions or not

2 participants

@0xprames @mattsse