Skip to content

chore(rpc-types): remove EngineRpcError#3975

Merged
mattsse merged 1 commit intomainfrom
dan/remove-engine-rpc-error-type
Jul 28, 2023
Merged

chore(rpc-types): remove EngineRpcError#3975
mattsse merged 1 commit intomainfrom
dan/remove-engine-rpc-error-type

Conversation

@Rjected
Copy link
Member

@Rjected Rjected commented Jul 27, 2023

Removes the EngineRpcError type, which was used briefly before the engine RPC API was simplified.

@Rjected Rjected added C-debt A clean up/refactor of existing code A-rpc Related to the RPC implementation A-consensus Related to the consensus engine labels Jul 27, 2023
@Rjected Rjected requested a review from mattsse as a code owner July 27, 2023 21:56
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #3975 (fb52fb6) into main (369b9a7) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

see 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.38% <ø> (+<0.01%) ⬆️
unit-tests 64.42% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.16% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.18% <ø> (-0.56%) ⬇️
networking 77.64% <ø> (ø)
rpc 58.45% <ø> (+0.09%) ⬆️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.81% <ø> (-0.02%) ⬇️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Jul 28, 2023
Merged via the queue into main with commit efd4895 Jul 28, 2023
@mattsse mattsse deleted the dan/remove-engine-rpc-error-type branch July 28, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-consensus Related to the consensus engine A-rpc Related to the RPC implementation C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants