Skip to content

fix(cli): eta div by zero#3971

Merged
mattsse merged 2 commits intomainfrom
rkrasiuk/fix-div-by-zero
Jul 27, 2023
Merged

fix(cli): eta div by zero#3971
mattsse merged 2 commits intomainfrom
rkrasiuk/fix-div-by-zero

Conversation

@rkrasiuk
Copy link
Contributor

@rkrasiuk rkrasiuk commented Jul 27, 2023

Description

Fix possible division by zero in eta calculation.

Screenshot_2023-07-27_at_19 49 05

@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior A-cli Related to the reth CLI labels Jul 27, 2023
@rkrasiuk rkrasiuk requested a review from onbjerg as a code owner July 27, 2023 17:01
@rkrasiuk rkrasiuk requested a review from mattsse July 27, 2023 17:01
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/fix-div-by-zero branch from b11dc11 to 872ebbc Compare July 27, 2023 17:07
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #3971 (3e23a7c) into main (a298756) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/node/events.rs 12.88% <0.00%> (-0.07%) ⬇️

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.51% <0.00%> (-0.03%) ⬇️
unit-tests 64.46% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.16% <0.00%> (-0.01%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.18% <ø> (-0.59%) ⬇️
networking 77.63% <ø> (-0.09%) ⬇️
rpc 58.75% <ø> (ø)
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.82% <ø> (+0.02%) ⬆️

@mattsse mattsse added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 465f0dc Jul 27, 2023
@mattsse mattsse deleted the rkrasiuk/fix-div-by-zero branch July 27, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Related to the reth CLI C-bug An unexpected or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants