Skip to content

add defaults to some rpc server cli args#3969

Merged
mattsse merged 2 commits intoparadigmxyz:mainfrom
alessandromazza98:issue3963
Jul 28, 2023
Merged

add defaults to some rpc server cli args#3969
mattsse merged 2 commits intoparadigmxyz:mainfrom
alessandromazza98:issue3963

Conversation

@alessandromazza98
Copy link
Contributor

@alessandromazza98 alessandromazza98 commented Jul 27, 2023

Closes #3963

This PR adds a default value and also removes the Option for the following fields:

  • auth_addr
  • ws_addr
  • ws_port
  • http_addr
  • http_port

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mattsse mattsse added A-rpc Related to the RPC implementation A-cli Related to the reth CLI labels Jul 27, 2023
@alessandromazza98
Copy link
Contributor Author

Got the errors, tomorrow I'll fix it

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #3969 (9760382) into main (e651a18) will decrease coverage by 0.12%.
Report is 14 commits behind head on main.
The diff coverage is 53.33%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/args/rpc_server_args.rs 50.50% <53.33%> (-0.51%) ⬇️

... and 25 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.37% <0.00%> (+0.82%) ⬆️
unit-tests 64.42% <53.33%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.12% <53.33%> (-0.04%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.58% <ø> (-1.01%) ⬇️
networking 77.67% <ø> (+<0.01%) ⬆️
rpc 58.43% <ø> (-0.32%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.82% <ø> (+<0.01%) ⬆️

@mattsse mattsse added this pull request to the merge queue Jul 28, 2023
Merged via the queue into paradigmxyz:main with commit b05b848 Jul 28, 2023
@alessandromazza98 alessandromazza98 deleted the issue3963 branch July 28, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Related to the reth CLI A-rpc Related to the RPC implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add defaults to some rpc server cli args

2 participants