Skip to content

chore: move some tests to engine crate#3968

Merged
Rjected merged 1 commit intomainfrom
matt/move-some-tests-to-engine-crate
Jul 27, 2023
Merged

chore: move some tests to engine crate#3968
Rjected merged 1 commit intomainfrom
matt/move-some-tests-to-engine-crate

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 27, 2023

ref #3964

extract some payload tests to engine crate so rpc-types no longer depends on reth-interfaces and reth testing tooling

@mattsse mattsse requested review from Rjected and gakonst as code owners July 27, 2023 16:12
@mattsse mattsse added the C-debt A clean up/refactor of existing code label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #3968 (d7012d5) into main (717bad8) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc-types/src/eth/engine/payload.rs 84.96% <ø> (-3.96%) ⬇️

... and 15 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.39% <ø> (+0.83%) ⬆️
unit-tests 64.49% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.18% <ø> (-0.01%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.56% <ø> (+0.56%) ⬆️
networking 77.64% <ø> (-0.06%) ⬇️
rpc 58.37% <ø> (-0.38%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.81% <ø> (-0.01%) ⬇️

@Rjected Rjected added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 68a74b2 Jul 27, 2023
@Rjected Rjected deleted the matt/move-some-tests-to-engine-crate branch July 27, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants