Add price bump config#3967
Add price bump config#3967mattsse merged 2 commits intoparadigmxyz:mainfrom altugbakan:fee-bump-config
Conversation
Codecov Report
... and 17 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
nice,
almost there already
| #[derive(Debug, Clone)] | ||
| pub struct PriceBump(u128); |
There was a problem hiding this comment.
while I like having default::default,
I think this adds more complexity than it is useful,
I'm okay with just using u128 as fields ins PriceBumpConfig
| transaction.as_ref(), | ||
| entry.get().transaction.as_ref(), | ||
| PRICE_BUMP, | ||
| PriceBumpConfig::default().default_price_bump.into(), |
There was a problem hiding this comment.
we want this as a field in PoolConfig
There was a problem hiding this comment.
I made some changes but I'm not sure if it is the intended solution.
|
@mattsse was if Self::is_underpriced(
transaction.as_ref(),
entry.get().transaction.as_ref(),
PoolConfig::default().price_bump,
) {what you meant? |
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
awesome!
this is great,
once we support blob tx we can easily integrate this as well
|
|
||
| /// Price bump (in %) for the transaction pool underpriced check. | ||
| #[arg(long = "txpool.price_bump", help_heading = "TxPool", default_value_t = DEFAULT_PRICE_BUMP)] | ||
| pub price_bump: u128, |
2 participants
Fixes #3945
This pull request adds a
PriceBumpConfigstruct for making fee bump rules configurable.