Skip to content

chore: make auth-port default #3962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 1 commit into from
Jul 27, 2023
Merged

chore: make auth-port default #3962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bin/reth/src/args/rpc_server_args.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ pub struct RpcServerArgs {
pub auth_addr: Option<IpAddr>,

/// Auth server port to listen on
#[arg(long = "authrpc.port")]
pub auth_port: Option<u16>,
#[arg(long = "authrpc.port", default_value_t = constants::DEFAULT_AUTH_PORT)]
pub auth_port: u16,

/// Path to a JWT secret to use for authenticated RPC endpoints
#[arg(long = "authrpc.jwtsecret", value_name = "PATH", global = true, required = false)]
Expand Down Expand Up @@ -358,7 +358,7 @@ impl RpcServerArgs {
{
let socket_address = SocketAddr::new(
self.auth_addr.unwrap_or(IpAddr::V4(Ipv4Addr::LOCALHOST)),
self.auth_port.unwrap_or(constants::DEFAULT_AUTH_PORT),
self.auth_port,
);

reth_rpc_builder::auth::launch(
Expand Down Expand Up @@ -459,7 +459,7 @@ impl RpcServerArgs {
fn auth_server_config(&self, jwt_secret: JwtSecret) -> Result<AuthServerConfig, RpcError> {
let address = SocketAddr::new(
self.auth_addr.unwrap_or(IpAddr::V4(Ipv4Addr::LOCALHOST)),
self.auth_port.unwrap_or(constants::DEFAULT_AUTH_PORT),
self.auth_port,
);

Ok(AuthServerConfig::builder(jwt_secret).socket_addr(address).build())
Expand Down