Skip to content

chore: move some functions to Cli struct#3961

Merged
mattsse merged 1 commit intomainfrom
matt/move-cli-around
Jul 27, 2023
Merged

chore: move some functions to Cli struct#3961
mattsse merged 1 commit intomainfrom
matt/move-cli-around

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 27, 2023

some prep for making it customizeable

@mattsse mattsse requested review from gakonst and onbjerg as code owners July 27, 2023 14:46
@mattsse mattsse added C-debt A clean up/refactor of existing code A-cli Related to the reth CLI labels Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #3961 (84a4a85) into main (717bad8) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/cli.rs 20.23% <0.00%> (-0.75%) ⬇️
crates/tracing/src/lib.rs 11.32% <ø> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.55% <0.00%> (-0.01%) ⬇️
unit-tests 64.54% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.17% <0.00%> (-0.02%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.56% <ø> (+0.56%) ⬆️
networking 77.68% <ø> (-0.02%) ⬇️
rpc 58.74% <ø> (-0.02%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.80% <ø> (-0.03%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good docs on the guard

@mattsse mattsse added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 2aae8c8 Jul 27, 2023
@mattsse mattsse deleted the matt/move-cli-around branch July 27, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Related to the reth CLI C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants