feat: store logs in different folders based on the chain

[alessandromazza98]

Closes #3858

When --log.persistent flag is enabled, logs are now stored in different folders based on the chain or in the already-chain-specific --datadir.

Examples (no --datadir flag):
~/.cache/reth/logs/mainnet/reth.log
~/.cache/reth/logs/sepolia/reth.log

Examples (with --datadir flag):
~/custom-data-dir/reth.log

[codecov]

Codecov Report

Merging #3948 (86deeff) into main (56b2ef1) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 65.00%.

Files Changed	Coverage Δ
bin/reth/src/dirs.rs	71.01% <0.00%> (-1.58%)	⬇️
bin/reth/src/cli.rs	34.40% <76.47%> (+12.33%)	⬆️

... and 8 files with indirect coverage changes

Flag	Coverage Δ
integration-tests	16.34% <0.00%> (-0.01%)	⬇️
unit-tests	64.31% <65.00%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	26.88% <65.00%> (+0.20%)	⬆️
blockchain tree	83.04% <ø> (ø)
pipeline	89.82% <ø> (ø)
storage (db)	74.30% <ø> (ø)
trie	94.70% <ø> (ø)
txpool	45.40% <ø> (-0.61%)	⬇️
networking	77.62% <ø> (-0.05%)	⬇️
rpc	58.52% <ø> (ø)
consensus	63.51% <ø> (ø)
revm	33.08% <ø> (ø)
payload builder	6.58% <ø> (ø)
primitives	87.92% <ø> (-0.02%)	⬇️

[Rjected]

looks like a good start! is it possible to get a CLI test for this?

for example like the ones here:

reth/bin/reth/src/node/mod.rs

Lines 879 to 890 in f3a7ae1

	#[test]
	fn parse_db_path() {
	let cmd = Command::try_parse_from(["reth"]).unwrap();
	let data_dir = cmd.datadir.unwrap_or_chain_default(cmd.chain.chain);
	let db_path = data_dir.db_path();
	assert!(db_path.ends_with("reth/mainnet/db"), "{:?}", cmd.config);
	let cmd = Command::try_parse_from(["reth", "--datadir", "my/custom/path"]).unwrap();
	let data_dir = cmd.datadir.unwrap_or_chain_default(cmd.chain.chain);
	let db_path = data_dir.db_path();
	assert_eq!(db_path, Path::new("my/custom/path/db"));
	}

[alessandromazza98]

At the end I chose the following option:

• keep logs and datadir directories separate, always using the Logs directory for logs.

This actually turned out the best decision because you can delete some fields to the Cli struct: the datadir field because it is no longer needed since logs are always stored in their specific directory, which is tied to the chain's name.

I also added a test to verify that the directory is properly parsed.

Let me know what do you think.

[onbjerg]

Makes sense to me, thank you. There are some conflicts to solve

[Rjected]

Makes sense and looks good to me! thank you!