Conversation
Codecov Report
... and 8 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Rjected
left a comment
Rjected
left a comment
There was a problem hiding this comment.
just wondering about beaconBlockRoot, I think we'll also need followups to add some of the new fields to other engine types
| versioned_hashes: Vec<H256>, | ||
| ) -> RpcResult<PayloadStatus>; |
There was a problem hiding this comment.
does this also need beaconBlockRoot?
Just looking at this: https://github.com/ethereum/execution-apis/blob/main/src/engine/cancun.md#engine_newpayloadv3
There was a problem hiding this comment.
| #[method(name = "newPayloadV3")] | ||
| async fn new_payload_v3( | ||
| &self, | ||
| payload: ExecutionPayload, |
There was a problem hiding this comment.
we'll need to modify ExecutionPayload to include dataGasUsed and excessGasUsed
There was a problem hiding this comment.
will do this after we have this added to the header as well
|
added missing arg just realized there's a cancun readme, but will do the remaining functions separately |
4 participants
ref #2893
not announced via caps yet, but adds the definitions