Skip to content

fix: prevent child call out of bounds#3920

Merged
onbjerg merged 3 commits intomainfrom
matt/fix-out-of-bounds
Jul 31, 2023
Merged

fix: prevent child call out of bounds#3920
onbjerg merged 3 commits intomainfrom
matt/fix-out-of-bounds

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 26, 2023

Closes #3915

prevents an out of bounds access if there is no call recorded for failed calls

for example

image

I still need to fully verify this

this is the correct fix for 0x6279ddfc4eb98b38ebf2119b6381c0265d4b8137af407e57b6c4f52996225eae and 0x5745d002debfd23b9db3975d4498d41353a678f04e4acd106c61fc78c4184a7a

@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #3920 (54f11f5) into main (73652ed) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/revm/revm-inspectors/src/tracing/mod.rs 0.00% <ø> (ø)
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.34% <0.00%> (-0.01%) ⬇️
unit-tests 64.31% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.67% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 45.40% <ø> (ø)
networking 77.64% <ø> (-0.03%) ⬇️
rpc 58.49% <ø> (-0.02%) ⬇️
consensus 63.51% <ø> (ø)
revm 33.10% <0.00%> (+0.01%) ⬆️
payload builder 6.58% <ø> (ø)
primitives 87.93% <ø> (-0.01%) ⬇️

@onbjerg onbjerg added C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog labels Jul 26, 2023
@mattsse mattsse marked this pull request as ready for review July 31, 2023 12:23
@mattsse mattsse requested review from Rjected and rkrasiuk July 31, 2023 12:27
Copy link
Contributor

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit da3bc64 Jul 31, 2023
@onbjerg onbjerg deleted the matt/fix-out-of-bounds branch July 31, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

code: -32603, internal error while tracing

3 participants