Merged
Conversation
shekhirin
requested review from
gakonst,
joshieDo,
onbjerg,
rakita and
rkrasiuk
as code owners
Codecov Report
... and 12 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shekhirin
added
C-enhancement
mattsse
approved these changes
Jul 25, 2023
crates/prune/src/pruner.rs
Outdated
Comment on lines
203
to
206
Collaborator
There was a problem hiding this comment.
this looks correct but I'd appreciate a note about batch logic
shekhirin
force-pushed
the
alexey/pruner-transaction-lookup
branch
from
4e42e78 to
6ba3ea4
Compare
shekhirin
force-pushed
the
alexey/pruner-transaction-lookup
branch
from
6ba3ea4 to
7228862
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3696
This PR adds pruning of transaction lookup entries from the
TxHashNumbertable. It works in the following way:TxHashNumberhas hashes as keys (hence, ordered by hashes), we need to retrieve the hashes for transaction numbers first. We do that in batches of 10k. So, for each 10k batch of transaction numbers, resolve their hashes in parallel.10k transactions take around 2MB in the memory, so we can increase batch size to decrease the number of random jumps needed during the deletion. But we also need to benchmark that.