Conversation
rkrasiuk
added
A-tx-pool
mattsse
reviewed
Jul 24, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this doesn't look too bad, but we should also check for btreemap
onbjerg
force-pushed
the
rkrasiuk/bench-txpool-reordering
branch
from
43b2384 to
7db9741
Compare
Collaborator
|
Rebased |
rkrasiuk
force-pushed
the
rkrasiuk/bench-txpool-reordering
branch
from
7db9741 to
c561e59
Compare
Codecov Report
... and 23 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bench transaction pool reordering for upcoming ordering fix to transaction pool (ref #3853).
Bench Routine
After the testdata is generated, the benchmarked block first invokes
reorderwhich sorts the inner collection, then adds a bunch of new transactions and resorts with a different base fee.seed sizeis the current size of the pool.Sampled
seed sizevalues:[1 000, 10 000, 50 000, 100 000]input sizeis the number of new transactions that will be added in between the reorderings.Sampled
input sizevalues:[10, 100, 1 000]The benchmark samples measurements across 4 different implementations. See code for more details.
You can run the benchmark with the following command:
Results
seed size: 1 000; input size: 10
seed size: 1 000; input size: 100
seed size: 1 000; input size: 1 000
seed size: 10 000; input size: 10
seed size: 10 000; input size: 100
seed size: 10 000; input size: 1 000
seed size: 50 000; input size: 10
seed size: 50 000; input size: 100
seed size: 50 000; input size: 1 000
seed size: 100 000; input size: 10, 100, 1 000
Skipped
VecTxPoolSortStableAndOnInsertstarted taking too long and is now removed.