feat: metric of reorg depth of blockchain tree#3860
Conversation
|
test result: root@test:~# curl http://127.0.0.1:9001 | grep latest_reorg
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 27701 100 27701 0 0 13.2M 0 --:--:-- --:--:-- --:--:-- 13.2M
# HELP reth_blockchain_tree_latest_reorg_depth The latest reorg depth
# TYPE reth_blockchain_tree_latest_reorg_depth gauge
reth_blockchain_tree_latest_reorg_depth 0@Rjected PTAL |
|
hmm, i'd rather use a Histogram and plot it as a histogram over time on the dashboard. curious to hear your thoughts @onbjerg |
Not sure wym here, histogram support in the metrics crate we use is kind of not the best, I don't remember the exact issue, but the buckets are not configurable, so might not be worth? Up to you |
|
It would be good to know the specific deficiencies with |
Codecov Report
... and 9 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@Rjected updated! |
fixes part of #3817