feat(pruner, storage): prune receipts & save checkpoints to database#3733
Merged
feat(pruner, storage): prune receipts & save checkpoints to database#3733
Conversation
shekhirin
added
C-enhancement
shekhirin
force-pushed
the
alexey/pruner-receipts
branch
from
4c0b0c5 to
bd644cd
Compare
shekhirin
force-pushed
the
alexey/pruner-receipts
branch
from
72f0db0 to
6278abb
Compare
shekhirin
force-pushed
the
alexey/pruner-receipts
branch
from
6278abb to
7771c93
Compare
shekhirin
force-pushed
the
alexey/pruner-receipts
branch
from
5ff7dc6 to
b46518b
Compare
Codecov Report
... and 12 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shekhirin
requested review from
Rjected,
joshieDo,
mattsse,
onbjerg,
rakita and
rkrasiuk
as code owners
joshieDo
approved these changes
Jul 17, 2023
mattsse
approved these changes
Jul 18, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this looks very clean and was easy to follow.
tests also look great
| storage_history | ||
| /// Returns block up to which pruning needs to be done, inclusive, according to the provided | ||
| /// prune mode and tip. | ||
| pub fn prune_to_block(&self, mode: &PruneMode, tip: BlockNumber) -> BlockNumber { |
Collaborator
There was a problem hiding this comment.
maybe prune_target_block?
Collaborator
There was a problem hiding this comment.
follow-up PR will change the name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3697
Adds pruning of receipts the the Pruner which is activated during the live sync. Pruning of receipts is done in one go, and the progress is printed every 10k receipts. After pruning is done, writes checkpoints to the database.