Skip to content

refactor: Stage execute and unwind take an immutable provider reference instead#3390

Merged
joshieDo merged 4 commits intomainfrom
stage/immutable
Jun 27, 2023
Merged

refactor: Stage execute and unwind take an immutable provider reference instead#3390
joshieDo merged 4 commits intomainfrom
stage/immutable

Conversation

@joshieDo
Copy link
Collaborator

No need for mutable reference anymore

@joshieDo joshieDo added A-staged-sync Related to staged sync (pipelines and stages) C-debt A clean up/refactor of existing code labels Jun 26, 2023
@joshieDo joshieDo requested a review from mattsse June 26, 2023 15:33
@joshieDo joshieDo added the S-blocked This cannot more forward until something else changes label Jun 26, 2023
@joshieDo
Copy link
Collaborator Author

blocked by #3384

@joshieDo joshieDo removed the S-blocked This cannot more forward until something else changes label Jun 27, 2023
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

no longer blocked @joshieDo

@joshieDo joshieDo enabled auto-merge June 27, 2023 12:56
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #3390 (692a675) into main (085a703) will increase coverage by 0.02%.
The diff coverage is 63.95%.

Impacted file tree graph

Impacted Files Coverage Δ
bin/reth/src/debug_cmd/merkle.rs 1.18% <0.00%> (ø)
bin/reth/src/stage/dump/execution.rs 0.00% <0.00%> (ø)
bin/reth/src/stage/dump/hashing_account.rs 0.00% <0.00%> (ø)
bin/reth/src/stage/dump/hashing_storage.rs 0.00% <0.00%> (ø)
bin/reth/src/stage/dump/merkle.rs 0.00% <0.00%> (ø)
bin/reth/src/stage/run.rs 1.39% <0.00%> (ø)
crates/stages/src/stage.rs 96.38% <ø> (ø)
testing/ef-tests/src/cases/blockchain_test.rs 4.87% <0.00%> (+0.11%) ⬆️
crates/stages/src/pipeline/mod.rs 86.92% <100.00%> (ø)
crates/stages/src/stages/bodies.rs 90.54% <100.00%> (ø)
... and 13 more

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.29% <0.00%> (-0.01%) ⬇️
unit-tests 64.30% <63.95%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.46% <0.00%> (ø)
blockchain tree 81.36% <ø> (ø)
pipeline 88.02% <100.00%> (+<0.01%) ⬆️
storage (db) 73.99% <ø> (ø)
trie 95.64% <ø> (ø)
txpool 51.88% <ø> (+0.64%) ⬆️
networking 77.90% <ø> (-0.01%) ⬇️
rpc 58.08% <ø> (-0.01%) ⬇️
consensus/evm 46.83% <ø> (ø)
payload builder 6.83% <ø> (ø)
primitives 88.61% <ø> (-0.02%) ⬇️

@joshieDo joshieDo added this pull request to the merge queue Jun 27, 2023
Merged via the queue into main with commit e10ab38 Jun 27, 2023
@joshieDo joshieDo deleted the stage/immutable branch June 27, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-staged-sync Related to staged sync (pipelines and stages) C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants