Skip to content

test(ethereum): ignore invalid string sequence in ethereum state tests#3307

Merged
mattsse merged 2 commits intomainfrom
alexey/fix-ef-tests
Jun 21, 2023
Merged

test(ethereum): ignore invalid string sequence in ethereum state tests#3307
mattsse merged 2 commits intomainfrom
alexey/fix-ef-tests

Conversation

@shekhirin
Copy link
Member

@shekhirin shekhirin commented Jun 21, 2023

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #3307 (1e1476d) into main (8fd3cd2) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3307      +/-   ##
==========================================
- Coverage   69.73%   69.69%   -0.05%     
==========================================
  Files         530      530              
  Lines       71545    71546       +1     
==========================================
- Hits        49894    49866      -28     
- Misses      21651    21680      +29     
Flag Coverage Δ
integration-tests 16.40% <0.00%> (+0.02%) ⬆️
unit-tests 64.73% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
testing/ef-tests/src/models.rs 28.65% <0.00%> (-0.17%) ⬇️

... and 11 files with indirect coverage changes

@shekhirin shekhirin force-pushed the alexey/fix-ef-tests branch 2 times, most recently from 3528d8e to 737ea70 Compare June 21, 2023 18:13
@shekhirin shekhirin changed the title fix ef-tests test(ethereum): fix invalid string sequence in ethereum state tests Jun 21, 2023
@shekhirin shekhirin force-pushed the alexey/fix-ef-tests branch from 737ea70 to 1e1476d Compare June 21, 2023 18:15
@shekhirin shekhirin marked this pull request as ready for review June 21, 2023 18:30
@shekhirin shekhirin requested a review from gakonst as a code owner June 21, 2023 18:30
@shekhirin shekhirin requested a review from mattsse June 21, 2023 18:30
@shekhirin shekhirin changed the title test(ethereum): fix invalid string sequence in ethereum state tests test(ethereum): ignore invalid string sequence in ethereum state tests Jun 21, 2023
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt, making mental note here that this will potentially break again soon

@mattsse mattsse added this pull request to the merge queue Jun 21, 2023
@onbjerg onbjerg added C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test labels Jun 21, 2023
Merged via the queue into main with commit 7b77fc1 Jun 21, 2023
@mattsse mattsse deleted the alexey/fix-ef-tests branch June 21, 2023 19:39
shekhirin added a commit that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants