Conversation
* decode 0x80 into zero explicitly
|
The author of this PR, Rjected, is not an activated member of this organization on Codecov. |
|
It's more explicit than having to dive into |
rakita
left a comment
There was a problem hiding this comment.
rlp is generally simple to get (even with complex rules that it has), This seems like a good writing: https://ethereum.org/en/developers/docs/data-structures-and-encoding/rlp/
This is just shifting some code to be more as shemnom said explicit, if you want move rest of checks from https://github.com/vorot93/fastrlp/blob/468fdf24608737d979e9b41276c3b91a47981c55/src/decode.rs#L168-L185 to appropriate place
|
makes sense, we can check which ones should be moved in a follow up |
Add support for `debug_executionWitness` API. This hasn't been tested, but I'll be able to test it soon once the backfill job completes. This code is mostly copied from here and adapted to work with our state provider: https://github.com/op-rs/op-reth/blob/1470a9cc77af798c999da05d9541a7025e5d4924/crates/rpc/rpc/src/debug.rs#L643-L695 Fixes paradigmxyz#190
Add support for `debug_executionWitness` API. This hasn't been tested, but I'll be able to test it soon once the backfill job completes. This code is mostly copied from here and adapted to work with our state provider: https://github.com/op-rs/op-reth/blob/1470a9cc77af798c999da05d9541a7025e5d4924/crates/rpc/rpc/src/debug.rs#L643-L695 Fixes paradigmxyz#190
Add support for `debug_executionWitness` API. This hasn't been tested, but I'll be able to test it soon once the backfill job completes. This code is mostly copied from here and adapted to work with our state provider: https://github.com/op-rs/op-reth/blob/1470a9cc77af798c999da05d9541a7025e5d4924/crates/rpc/rpc/src/debug.rs#L643-L695 Fixes paradigmxyz#190
Add support for `debug_executionWitness` API. This hasn't been tested, but I'll be able to test it soon once the backfill job completes. This code is mostly copied from here and adapted to work with our state provider: https://github.com/op-rs/op-reth/blob/1470a9cc77af798c999da05d9541a7025e5d4924/crates/rpc/rpc/src/debug.rs#L643-L695 Fixes paradigmxyz#190
The previous method correctly decodes
0x80, but this makes it an explicit case and adds a comment about what happens when0x80is decoded as an integer.