Skip to content

chore(rlp): add comment on 0x80 decoding#312

Merged
Rjected merged 2 commits intomainfrom
dan/comment-zero-encoding
Dec 2, 2022
Merged

chore(rlp): add comment on 0x80 decoding#312
Rjected merged 2 commits intomainfrom
dan/comment-zero-encoding

Conversation

@Rjected
Copy link
Member

@Rjected Rjected commented Dec 1, 2022

The previous method correctly decodes 0x80, but this makes it an explicit case and adds a comment about what happens when 0x80 is decoded as an integer.

@codecov
Copy link

codecov bot commented Dec 1, 2022

The author of this PR, Rjected, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

@Rjected Rjected added C-docs An addition or correction to our documentation A-utils Related to commonly used utilities labels Dec 1, 2022
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by no means an rlp expert, so curios what @rakita thinks

@shemnon
Copy link
Contributor

shemnon commented Dec 1, 2022

It's more explicit than having to dive into from_big_endian and from_be_bytes to see how they deal with zero-length arrays.

Copy link
Collaborator

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rlp is generally simple to get (even with complex rules that it has), This seems like a good writing: https://ethereum.org/en/developers/docs/data-structures-and-encoding/rlp/

This is just shifting some code to be more as shemnom said explicit, if you want move rest of checks from https://github.com/vorot93/fastrlp/blob/468fdf24608737d979e9b41276c3b91a47981c55/src/decode.rs#L168-L185 to appropriate place

@Rjected
Copy link
Member Author

Rjected commented Dec 2, 2022

makes sense, we can check which ones should be moved in a follow up

@Rjected Rjected merged commit bc3702e into main Dec 2, 2022
@Rjected Rjected deleted the dan/comment-zero-encoding branch December 2, 2022 02:27
emhane pushed a commit to JoshdfG/reth that referenced this pull request Jan 5, 2026
Add support for `debug_executionWitness` API. This hasn't been tested,
but I'll be able to test it soon once the backfill job completes.

This code is mostly copied from here and adapted to work with our state
provider:
https://github.com/op-rs/op-reth/blob/1470a9cc77af798c999da05d9541a7025e5d4924/crates/rpc/rpc/src/debug.rs#L643-L695

Fixes paradigmxyz#190
JoshdfG pushed a commit to JoshdfG/reth that referenced this pull request Jan 16, 2026
Add support for `debug_executionWitness` API. This hasn't been tested,
but I'll be able to test it soon once the backfill job completes.

This code is mostly copied from here and adapted to work with our state
provider:
https://github.com/op-rs/op-reth/blob/1470a9cc77af798c999da05d9541a7025e5d4924/crates/rpc/rpc/src/debug.rs#L643-L695

Fixes paradigmxyz#190
emhane pushed a commit to JoshdfG/reth that referenced this pull request Jan 21, 2026
Add support for `debug_executionWitness` API. This hasn't been tested,
but I'll be able to test it soon once the backfill job completes.

This code is mostly copied from here and adapted to work with our state
provider:
https://github.com/op-rs/op-reth/blob/1470a9cc77af798c999da05d9541a7025e5d4924/crates/rpc/rpc/src/debug.rs#L643-L695

Fixes paradigmxyz#190
dhyaniarun1993 pushed a commit to dhyaniarun1993/reth that referenced this pull request Feb 23, 2026
Add support for `debug_executionWitness` API. This hasn't been tested,
but I'll be able to test it soon once the backfill job completes.

This code is mostly copied from here and adapted to work with our state
provider:
https://github.com/op-rs/op-reth/blob/1470a9cc77af798c999da05d9541a7025e5d4924/crates/rpc/rpc/src/debug.rs#L643-L695

Fixes paradigmxyz#190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-utils Related to commonly used utilities C-docs An addition or correction to our documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants