fix: exclude calls to precompiles in parity tracers#2987
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2987 +/- ##
==========================================
- Coverage 70.86% 70.84% -0.02%
==========================================
Files 520 520
Lines 68260 68294 +34
==========================================
+ Hits 48372 48383 +11
- Misses 19888 19911 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Collaborator
Currently, you can't, but we can move procompiles to |
11b8580 to
19d940d
Compare
19d940d to
634b13c
Compare
gakonst
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #2970
This adds a
is_precompilemarker to the tracer types and excludes nodes that are precompiles@rakita how do I find out if a call is to a precompile?UPDATE
This currently patches https://github.com/bluealloy/revm/tree/release/v25
@rakita what#s the ETA for revm release that includes this?