Skip to content

fix: exclude calls to precompiles in parity tracers#2987

Merged
gakonst merged 2 commits intomainfrom
matt/exclude-precompiles-in-parity
Jun 6, 2023
Merged

fix: exclude calls to precompiles in parity tracers#2987
gakonst merged 2 commits intomainfrom
matt/exclude-precompiles-in-parity

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 5, 2023

ref #2970

This adds a is_precompile marker to the tracer types and excludes nodes that are precompiles

@rakita how do I find out if a call is to a precompile?

UPDATE

This currently patches https://github.com/bluealloy/revm/tree/release/v25
@rakita what#s the ETA for revm release that includes this?

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #2987 (db86e7b) into main (2e11c6f) will decrease coverage by 0.02%.
The diff coverage is 3.22%.

@@            Coverage Diff             @@
##             main    #2987      +/-   ##
==========================================
- Coverage   70.86%   70.84%   -0.02%     
==========================================
  Files         520      520              
  Lines       68260    68294      +34     
==========================================
+ Hits        48372    48383      +11     
- Misses      19888    19911      +23     
Flag Coverage Δ
integration-tests 17.04% <3.22%> (+<0.01%) ⬆️
unit-tests 65.80% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...revm/revm-inspectors/src/tracing/builder/parity.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/mod.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/config.rs 30.35% <14.28%> (-2.30%) ⬇️

... and 8 files with indirect coverage changes

@rakita
Copy link
Collaborator

rakita commented Jun 5, 2023

ref #2970

This adds a is_precompile marker to the tracer types and excludes nodes that are precompiles

@rakita how do I find out if a call is to a precompile?

Currently, you can't, but we can move procompiles to EVMData. PR here: bluealloy/revm#504

@mattsse mattsse force-pushed the matt/exclude-precompiles-in-parity branch from 11b8580 to 19d940d Compare June 6, 2023 10:49
@mattsse mattsse force-pushed the matt/exclude-precompiles-in-parity branch from 19d940d to 634b13c Compare June 6, 2023 12:32
@mattsse mattsse marked this pull request as ready for review June 6, 2023 13:07
@mattsse mattsse requested a review from gakonst as a code owner June 6, 2023 13:07
@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Jun 6, 2023
@gakonst gakonst added this pull request to the merge queue Jun 6, 2023
Merged via the queue into main with commit 8f4e37e Jun 6, 2023
@gakonst gakonst deleted the matt/exclude-precompiles-in-parity branch June 6, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior S-blocked This cannot more forward until something else changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants