fix(net): default discv5 to share the discv4 port#24377
Closed
mattsse wants to merge 1 commit into
Closed
Conversation
Discv5 was defaulting to UDP port 9200 while the enode URL advertised in admin_nodeInfo only contains the discv4 port (30303). External tools like hive's devp2p discv5 tester send discv5 packets to the port from the enode URL, so they timed out against a node that never listened on 30303. Defaulting `discv5_port`/`discv5_port_ipv6` to `None` makes them fall back to `--discovery.port`, activating the shared-port mode added in #23613. This matches geth's behavior of running discv4 and discv5 on the same UDP port and is what external testers expect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discv5 was defaulting to UDP port 9200 while the enode URL advertised in
admin_nodeInfoonly contains the discv4 port (30303). External tools like hive'sdevp2p discv5 testparse the enode URL and send discv5 packets to that port, so they timed out against a node that never listened on 30303.Defaulting
discv5_port/discv5_port_ipv6toNonemakes them fall back to--discovery.port, automatically activating the shared-port mode introduced in #23613. This matches geth's behavior of running discv4 and discv5 on the same UDP port and is what external testers expect.Verified locally against hive's
devp2psimulator with thediscv5suite: before this change all 7 cases time out; after,Ping,PingLargeRequestID,TalkRequestandFindnodeZeroDistancepass. The remaining cases (PingMultiIP,HandshakeResend,FindnodeResults) appear to be docker-network and sigp/discv5 library behavior that's outside the scope of this change.