feat: customizable discovery defaults#23843
Merged
Merged
Conversation
mattsse
approved these changes
Apr 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Thegreatsura
pushed a commit
to Thegreatsura/tempo
that referenced
this pull request
May 1, 2026
Automated nightly update of reth dependencies from `paradigmxyz/reth` main branch. ## Upstream reth changes [`077e5ee...fcfa828`](paradigmxyz/reth@077e5ee...fcfa828) 🔗 Amp thread: https://ampcode.com/threads/T-019ddc9d-1d46-75e9-b9e8-644c7bd4c595 - **Engine**: Apply finalized state after syncing FCU head import ([#23838](paradigmxyz/reth#23838)) - **Networking**: Customizable discovery defaults ([#23843](paradigmxyz/reth#23843)) - **DB**: Replace deprecated `MDBX_NOTLS` with `MDBX_NOSTICKYTHREADS` ([#23378](paradigmxyz/reth#23378)) ## Migrations 🔗 Amp thread: https://ampcode.com/threads/T-019ddc9d-2d98-72cb-aac1-a4da293cbabf - Bumped all `reth-*` git dependencies in `Cargo.toml` from rev `077e5ee` to `fcfa828` to pull in the latest upstream Reth SDK changes. [GitHub Workflow](https://github.com/tempoxyz/tempo/actions/runs/25147002830)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
DefaultDiscoveryArgsallowing to customize default values for discovery CLI args.More importantly, this PR changes discv5 port fields to be
Options instead. When those fields areNone, the regular--discovery.portis used, starting discv4 and discv5 on the same port as enabled by #23613Default behavior for reth is to still start discv5 on port 9200 but custom clients can now change this behavior by setting default values for discv5 port fields to
Noneand thus defaulting to both protocols launching at--discovery.port