Skip to content

fix(db): use sync=true for rocksdb WriteOptions#23603

Merged
klkvr merged 1 commit into
mainfrom
dan/sync-rocksdb-write-options
Apr 17, 2026
Merged

fix(db): use sync=true for rocksdb WriteOptions#23603
klkvr merged 1 commit into
mainfrom
dan/sync-rocksdb-write-options

Conversation

@Rjected
Copy link
Copy Markdown
Member

@Rjected Rjected commented Apr 17, 2026

No description provided.

@Rjected Rjected force-pushed the dan/sync-rocksdb-write-options branch from a5f6bcc to df32a5c Compare April 17, 2026 00:35
@Rjected
Copy link
Copy Markdown
Member Author

Rjected commented Apr 17, 2026

derek bench big-blocks

@decofe
Copy link
Copy Markdown
Member

decofe commented Apr 17, 2026

cc @Rjected

✅ Benchmark complete! View job

Benchmark Results

Metric main dan/sync-rocksdb-write-options Change
Mean 770.66ms 775.08ms +0.57% ⚪ (±1.44%)
StdDev 162.46ms 165.21ms
P50 737.04ms 740.88ms +0.52% ⚪ (±1.79%)
P90 966.31ms 977.92ms +1.20% ⚪ (±3.80%)
P99 1339.26ms 1370.92ms +2.36% ⚪ (±8.03%)
Mgas/s 1371.67 1364.00 -0.56% ⚪ (±1.20%)
Wall Clock 795.66s 799.69s +0.51% ⚪ (±1.64%)
Persist Wait 1.14ms 3.46ms +203.94% ⚪ (±272.41%)

500 big blocks, 20 warmup

Wait Time Breakdown

Persistence Wait

Metric main dan/sync-rocksdb-write-options
Mean 1.14ms 3.46ms
P50 0.06ms 0.06ms
P95 0.09ms 0.09ms

Trie Cache Update Wait

Metric main dan/sync-rocksdb-write-options
Mean 0.00ms 0.00ms
P50 0.00ms 0.00ms
P95 0.00ms 0.00ms

Execution Cache Update Wait

Metric main dan/sync-rocksdb-write-options
Mean 0.00ms 0.00ms
P50 0.00ms 0.00ms
P95 0.00ms 0.00ms

Grafana Dashboard

Charts

Latency, Throughput & Diff

Latency, Throughput & Diff

Wait Time Breakdown

Wait Time Breakdown

Gas vs Latency

Gas vs Latency

Grafana Dashboard

View real-time metrics

@shekhirin shekhirin marked this pull request as ready for review April 17, 2026 09:25
@github-project-automation github-project-automation Bot moved this from Backlog to In Progress in Reth Tracker Apr 17, 2026
@klkvr klkvr added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit 3a136fc Apr 17, 2026
34 checks passed
@klkvr klkvr deleted the dan/sync-rocksdb-write-options branch April 17, 2026 11:26
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Reth Tracker Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants