chore: bump alloy to 2.0.0#23407
Merged
Merged
Conversation
mattsse
reviewed
Apr 9, 2026
Collaborator
There was a problem hiding this comment.
this looks wrong, we shouldnt need this
Collaborator
There was a problem hiding this comment.
I'm pretty sure this is still wrong :)
Soubhik-10
reviewed
Apr 9, 2026
- Bump 27 alloy crate versions from 1.8.2 to 2.0.0-rc.1 - Bump alloy-hardforks from 0.4.5 to 0.4.7 - Add [patch.crates-io] for alloy, alloy-evm, revm-inspectors, reth-core - Add local TransactionEnvMut trait (removed from alloy-evm) - Handle ChainConfig non-exhaustive field (mutable default pattern) - Add Header fields: block_access_list_hash, slot_number - Add PayloadAttributes field: slot_number - Handle ExecutionPayload::V4 variant - Handle BlobTransactionSidecarVariant generic build Amp-Thread-ID: https://ampcode.com/threads/T-019d6e8f-76f3-74b9-83cb-a195677d4412 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d6e8f-76f3-74b9-83cb-a195677d4412 Co-authored-by: Amp <amp@ampcode.com>
- Remove unfulfilled #[expect(clippy::needless_update)] (8 instances) - Make deprioritize_background_threads const fn - Use pre-Osaka PooledTransaction type for old fixture data tests Amp-Thread-ID: https://ampcode.com/threads/T-019d6e8f-76f3-74b9-83cb-a195677d4412 Co-authored-by: Amp <amp@ampcode.com>
The inner _deprioritize_background_threads() does I/O on Linux and cannot be called in const context. Compiled on macOS only because the #[cfg(target_os = "linux")] body was excluded. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d6ffa-13e1-75b0-a1f4-b2fab3eb9653
stevencartavia
force-pushed
the
alloy-2.0
branch
from
49bc030 to
fb01204
Compare
mattsse
requested changes
Apr 10, 2026
Collaborator
There was a problem hiding this comment.
I'm pretty sure this is still wrong :)
Comment on lines
+105
to
+111
| let mut config = self.chain_spec.genesis().config.clone(); | ||
| config.chain_id = self.chain_spec.chain().id(); | ||
| config.terminal_total_difficulty_passed = | ||
| self.chain_spec.final_paris_total_difficulty().is_some(); | ||
| config.terminal_total_difficulty = | ||
| self.chain_spec.ethereum_fork_activation(EthereumHardfork::Paris).ttd(); | ||
| config.deposit_contract_address = self.chain_spec.deposit_contract().map(|dc| dc.address); |
klkvr
reviewed
Apr 13, 2026
Comment on lines
+464
to
+475
| self.executor.execute_transaction_with_commit_condition((tx_env, &tx), f)? | ||
| self.executor.execute_transaction_with_commit_condition((tx_env, &tx), |result| { | ||
| f(&result.result().result) | ||
| })? |
Member
There was a problem hiding this comment.
we want to change the closure type of the BlockBuilder trait so that it gets the inner Executor::Result
klkvr
approved these changes
Apr 13, 2026
mattsse
approved these changes
Apr 13, 2026
mattsse
requested review from
Rjected,
fgimenez,
gakonst,
joshieDo,
mediocregopher and
shekhirin
as code owners
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the temporary crate patches from this branch and switches the bump to the released crates: Alloy 2.0.0, alloy-evm 0.31.0, revm-inspectors 0.37.0, and the reth-core split crates at 0.2.0.
This also adapts
reth-evmto the finalalloy-evm 0.31.0commit callback signature. Verified withcargo +nightly fmt --all --check,cargo check --workspace --all-features --locked, andcargo nextest run -p reth-evm -p reth-rpc-eth-types --locked.