Skip to content

fix(rpc): apply count only after after is consumed #23338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 2 commits into from
Apr 2, 2026
Merged

fix(rpc): apply count only after after is consumed #23338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
578bbf1
fix(rpc): apply count only after after is consumed
crypomen9 Apr 2, 2026
9ad9690
chore(docs): remove unrelated admin diff
mattsse Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions crates/rpc/rpc/src/trace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,14 +454,16 @@ where
after = None;
}

// Return at most `count` of traces
if let Some(count) = count {
// Return at most `count` traces after `after` has been consumed.
if after.is_none() &&
let Some(count) = count
{
let count = count as usize;
if count < all_traces.len() {
all_traces.truncate(count);
return Ok(all_traces)
}
};
}
}

// If `after` is greater than or equal to the number of matched traces, it returns an
Expand Down
Loading