Skip to content

fix(cli): use HeaderTy for stage dump headers #23274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 1 commit into from
Mar 30, 2026
Merged

fix(cli): use HeaderTy for stage dump headers #23274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/cli/commands/src/stage/dump/execution.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use reth_db_api::{
};
use reth_db_common::DbTool;
use reth_evm::ConfigureEvm;
use reth_node_builder::NodeTypesWithDB;
use reth_node_api::HeaderTy;
use reth_node_core::dirs::{ChainPath, DataDirPath};
use reth_provider::{
providers::{ProviderNodeTypes, RocksDBProvider, StaticFileProvider},
Expand Down Expand Up @@ -58,7 +58,7 @@ where
}

/// Imports all the tables that can be copied over a range.
fn import_tables_with_range<N: NodeTypesWithDB>(
fn import_tables_with_range<N: ProviderNodeTypes>(
output_db: &DatabaseEnv,
db_tool: &DbTool<N>,
from: u64,
Expand All @@ -74,7 +74,7 @@ fn import_tables_with_range<N: NodeTypesWithDB>(
)
})??;
output_db.update(|tx| {
tx.import_table_with_range::<tables::Headers, _>(
tx.import_table_with_range::<tables::Headers<HeaderTy<N>>, _>(
&db_tool.provider_factory.db_ref().tx()?,
Some(from),
to,
Expand Down
3 changes: 2 additions & 1 deletion crates/cli/commands/src/stage/dump/merkle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ use reth_db_api::{database::Database, models::BlockNumberAddress, table::TableIm
use reth_db_common::DbTool;
use reth_evm::ConfigureEvm;
use reth_exex::ExExManagerHandle;
use reth_node_api::HeaderTy;
use reth_node_core::dirs::{ChainPath, DataDirPath};
use reth_provider::{
providers::{ProviderNodeTypes, RocksDBProvider, StaticFileProvider},
Expand Down Expand Up @@ -41,7 +42,7 @@ where
let (output_db, tip_block_number) = setup(from, to, &output_datadir.db(), db_tool)?;

output_db.update(|tx| {
tx.import_table_with_range::<tables::Headers, _>(
tx.import_table_with_range::<tables::Headers<HeaderTy<N>>, _>(
&db_tool.provider_factory.db_ref().tx()?,
Some(from),
to,
Expand Down
Loading