Closed
Conversation
shellexpand is broken with the latest nightly due to str::as_str() stabilization (rust-lang/rust#130366) shadowing Cow::as_str(). Replaces it with reusable expand_tilde() and expand_path() helpers in reth_node_core::utils, using dirs-next (already a dependency). Amp-Thread-ID: https://ampcode.com/threads/T-019c83d4-3dbb-74de-b8ef-e8f96afefb92 Co-authored-by: Amp <amp@ampcode.com>
Contributor
|
|
The stabilization of |
mattsse
reviewed
Feb 23, 2026
Collaborator
mattsse
left a comment
There was a problem hiding this comment.
can wait for fix and pin ci until then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
shellexpanddependency which is broken with the latest nightly due tostr::as_str()stabilization (rust-lang/rust#130366) shadowingCow::as_str().Changes
expand_tilde()andexpand_path()helpers inreth_node_core::utilsshellexpand::full()inreth-node-corewithexpand_path()shellexpand::tilde()inreth-bench-comparewithreth_node_core::utils::expand_tilde()shellexpand::full()inreth-cliwith localexpand_tilde()(usingdirs-next)shellexpandfrom workspace depsTesting
cargo +nightly clippy --workspace --lib --examples --tests --benches --all-features --lockedpasses clean.Prompted by: mattsse