test(prune): add tests verifying storage settings are respected for backend selection#21705
Closed
HuberyJulianay wants to merge 1 commit intoparadigmxyz:mainfrom
Closed
test(prune): add tests verifying storage settings are respected for backend selection#21705HuberyJulianay wants to merge 1 commit intoparadigmxyz:mainfrom
HuberyJulianay wants to merge 1 commit intoparadigmxyz:mainfrom
Conversation
HuberyJulianay
force-pushed
the
test/history-prune-dual-config
branch
from
c8cf216 to
5bd3057
Compare
HuberyJulianay
force-pushed
the
test/history-prune-dual-config
branch
2 times, most recently
from
147acfd to
925c29f
Compare
HuberyJulianay
force-pushed
the
test/history-prune-dual-config
branch
from
925c29f to
77759fe
Compare
github-actions
bot
added
the
S-stale
Member
|
Hey! We're doing some spring cleaning on our PR backlog 🧹 Closing old PRs to keep things tidy. If this is still relevant, please feel free to re-open — we appreciate your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests to ensure that when rocksdb feature is enabled but storage settings specify MDBX (account_history_in_rocksdb=false, storages_history_in_rocksdb=false), the pruner correctly uses the MDBX path and does not touch RocksDB data.
This addresses the integration testing suggestion from review: