Skip to content

fix(trie): PST: Fix update_leaf atomicity, remove update_leaves revealed tracking, fix callback calling#21573

Merged
mediocregopher merged 2 commits into
mainfrom
mediocregopher/update-leaf-atomicity-fix
Jan 29, 2026
Merged

fix(trie): PST: Fix update_leaf atomicity, remove update_leaves revealed tracking, fix callback calling#21573
mediocregopher merged 2 commits into
mainfrom
mediocregopher/update-leaf-atomicity-fix

Conversation

@mediocregopher
Copy link
Copy Markdown
Member

@mediocregopher mediocregopher commented Jan 29, 2026

  • Make SparseSubtrie::update_leaf properly atomic on errors
  • Don't do leaf reveal tracking in PST
  • Call the proof_required_fn callback with the path which is missing, not the original full_key
  • Pass B256 into proof_required_fn for compile-time correctness

@mediocregopher mediocregopher changed the title fix(trie): Fix atomicity in SparseSubtrie::update_leaf and remove update_leaves revealed tracking fix(trie): Fix atomicity in SparseSubtrie::update_leaf, remove update_leaves revealed tracking, fix callback calling Jan 29, 2026
@mediocregopher mediocregopher changed the title fix(trie): Fix atomicity in SparseSubtrie::update_leaf, remove update_leaves revealed tracking, fix callback calling fix(trie): PST: Fix update_leaf atomicity, remove update_leaves revealed tracking, fix callback calling Jan 29, 2026
@mediocregopher mediocregopher marked this pull request as ready for review January 29, 2026 16:11
@github-project-automation github-project-automation Bot moved this from Backlog to In Progress in Reth Tracker Jan 29, 2026
@mediocregopher mediocregopher added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main with commit 320f2a6 Jan 29, 2026
50 checks passed
@mediocregopher mediocregopher deleted the mediocregopher/update-leaf-atomicity-fix branch January 29, 2026 16:29
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Reth Tracker Jan 29, 2026
klkvr pushed a commit that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants