chore: remove unused docker from makefile#21445
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes deprecated Docker build infrastructure from the Makefile, replacing it with the newer docker-bake.hcl and Dockerfile.depot workflow. The old cross-compilation approach using separate Dockerfiles and custom Makefile targets has been superseded by the Docker Bake configuration that provides equivalent functionality.
Changes:
- Removed the
DOCKER_IMAGE_NAMEvariable and all Docker-related Makefile targets (both reth and op-reth variants) - Deleted
Dockerfile.crossandDockerfileOp.crossfiles that were used by the removed Makefile targets - Migrated to docker-bake.hcl which provides all the same build variants (nightly, profiling, edge-profiling) for both reth and op-reth
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile | Removed DOCKER_IMAGE_NAME variable and 137 lines of Docker build targets/functions for both reth and op-reth |
| Dockerfile.cross | Deleted cross-architecture Dockerfile for reth (replaced by docker-bake.hcl + Dockerfile.depot) |
| DockerfileOp.cross | Deleted cross-architecture Dockerfile for op-reth (replaced by docker-bake.hcl + Dockerfile.depot) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shekhirin
approved these changes
Jan 26, 2026
joshieDo
approved these changes
Jan 26, 2026
rakita
pushed a commit
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nightly builds use the new docker-bake.hcl and Dockerfile.depot