fix(stages): retain RocksDB TempDir in TestStageDB to prevent premature deletion#21444
Merged
joshieDo merged 1 commit intoparadigmxyz:mainfrom Jan 26, 2026
Merged
fix(stages): retain RocksDB TempDir in TestStageDB to prevent premature deletion#21444joshieDo merged 1 commit intoparadigmxyz:mainfrom
joshieDo merged 1 commit intoparadigmxyz:mainfrom
Conversation
ethfanWilliam
requested review from
mediocregopher and
shekhirin
as code owners
joshieDo
approved these changes
Jan 26, 2026
rakita
pushed a commit
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RocksDB temp directory was being dropped immediately after creation in both
TestStageDB::default()andTestStageDB::new(), while the path was still being used by RocksDBProvider. This could cause the directory to be deleted before RocksDB finished using it, leading to undefined behavior.Added
temp_rocksdb_dirfield to TestStageDB to keep the TempDir alive for the struct's lifetime, matching how we already handletemp_static_files_dir. Also matches the pattern used inprovider/src/test_utils/mod.rsandexex/test-utils/src/lib.rs.