refactor(trie): always use ParallelSparseTrie, deprecate config flags#21435
Merged
mediocregopher merged 2 commits intomainfrom Jan 26, 2026
Merged
refactor(trie): always use ParallelSparseTrie, deprecate config flags#21435mediocregopher merged 2 commits intomainfrom
mediocregopher merged 2 commits intomainfrom
Conversation
Member
mediocregopher
commented
Jan 26, 2026
mediocregopher
commented
- Deprecate --engine.disable-parallel-sparse-trie CLI flag (now no-op)
- Deprecate --engine.parallel-sparse-trie CLI flag (now no-op)
- Delete ConfiguredSparseTrie enum, use ParallelSparseTrie directly
- Rename SparseTrie enum to RevealableSparseTrie
- Rename SparseTrieInterface trait to SparseTrie
- Deprecate --engine.disable-parallel-sparse-trie CLI flag (now no-op) - Deprecate --engine.parallel-sparse-trie CLI flag (now no-op) - Delete ConfiguredSparseTrie enum, use ParallelSparseTrie directly - Rename SparseTrie<T> enum to RevealableSparseTrie<T> - Rename SparseTrieInterface trait to SparseTrie
mediocregopher
requested review from
Rjected,
klkvr,
mattsse,
shekhirin and
yongkangc
as code owners
shekhirin
added
C-debt
rakita
pushed a commit
that referenced
this pull request
Jan 26, 2026
Member
|
lfg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.