perf(db): flatten HashedPostState before persisting#21422
Merged
Conversation
Accumulate hashed state from all blocks using `HashedPostStateSorted::merge_batch` and write it in a single batch, reducing cursor open/close overhead from N calls to 1. This mirrors the existing optimization for trie updates. Closes #20609
Member
|
yongkangc
approved these changes
Jan 26, 2026
Member
yongkangc
left a comment
There was a problem hiding this comment.
nice, didnt know that reducing cursor overhead would be so big
mattsse
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accumulate hashed state from all blocks using
HashedPostStateSorted::merge_batchand write it in a single batch, reducing cursor open/close overhead from N calls to 1.This mirrors the existing optimization for trie updates (which was already batched).
Changes
write_hashed_statecall outside the per-block loopHashedPostStateSorted::merge_batchto combine all hashed states (newest-to-oldest)Closes #20609