fix(rpc): populate block_hash in eth_simulateV1 logs#21413
Merged
mattsse merged 1 commit intoparadigmxyz:mainfrom Jan 26, 2026
Merged
fix(rpc): populate block_hash in eth_simulateV1 logs#21413mattsse merged 1 commit intoparadigmxyz:mainfrom
mattsse merged 1 commit intoparadigmxyz:mainfrom
Conversation
The logs in eth_simulateV1 response were missing the block_hash field, returning null instead of the simulated block's hash. Amp-Thread-ID: https://ampcode.com/threads/T-019bf5ac-dd59-76c0-8ba8-8739e84b6a33 Co-authored-by: Amp <amp@ampcode.com>
klkvr
approved these changes
Jan 26, 2026
rakita
pushed a commit
that referenced
this pull request
Jan 26, 2026
Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The logs in
eth_simulateV1response were missing theblock_hashfield, returningnullinstead of the simulated block's hash.Test
Fixes hive test
eth_simulateV1/ethSimulate-eth-send-should-produce-logs: