fix(rpc): use correct error codes for eth_simulateV1 reverts and halts#21412
Merged
mattsse merged 1 commit intoparadigmxyz:mainfrom Jan 26, 2026
Merged
Conversation
Defines constants for eth_simulateV1 specific error codes: - SIMULATE_REVERT_CODE (-32000) for execution reverts - SIMULATE_VM_ERROR_CODE (-32015) for VM execution errors (e.g., out of gas) These match geth's behavior per the execution-apis spec. Amp-Thread-ID: https://ampcode.com/threads/T-019bf5ac-dd59-76c0-8ba8-8739e84b6a33 Co-authored-by: Amp <amp@ampcode.com>
mattsse
force-pushed
the
fix/eth-simulate-error-codes
branch
from
95ea466 to
f4d8b70
Compare
klkvr
approved these changes
Jan 26, 2026
rakita
pushed a commit
that referenced
this pull request
Jan 26, 2026
#21412) Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes error codes in
eth_simulateV1response to match geth:3(ExecutionError)-320003(ExecutionError)-32015Also sets
returnDatato empty bytes for reverts - the revert data will go inerror.dataonce alloy adds support (PR pending).Test
Fixes multiple hive
eth_simulateV1test failures including:ethSimulate-eth-send-should-not-produce-logs-on-revertethSimulate-run-out-of-gas-in-block-38015Related
error.datafield: pending