fix(engine): only warn for critical capability mismatches#21398
Merged
fix(engine): only warn for critical capability mismatches#21398
Conversation
Limit capability mismatch warnings to critical Engine API methods (forkchoiceUpdated, getPayload, newPayload) that are essential for block production and chain synchronization. Non-critical methods like engine_getBlobs are not warned about since not all clients support them and they're not required for operation. Amp-Thread-ID: https://ampcode.com/threads/T-019bf030-638d-712d-88a5-281bf095778c Co-authored-by: Amp <amp@ampcode.com>
mattsse
force-pushed
the
mattsse/fix-capability-warning
branch
from
b8e8c67 to
3f0afdf
Compare
rakita
pushed a commit
that referenced
this pull request
Jan 26, 2026
Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit capability mismatch warnings to critical Engine API methods (
engine_forkchoiceUpdated,engine_getPayload,engine_newPayload) that are essential for block production and chain synchronization.Non-critical methods like
engine_getBlobsare not warned about since not all clients support them and they're not required for operation.This prevents spurious warnings when CL clients don't support optional methods like
engine_getBlobsV3.