fix(node): make RocksDbArgs respect edge feature defaults like StaticFilesArgs does#21239
Closed
HuberyJulianay wants to merge 3 commits intoparadigmxyz:mainfrom
Closed
fix(node): make RocksDbArgs respect edge feature defaults like StaticFilesArgs does#21239HuberyJulianay wants to merge 3 commits intoparadigmxyz:mainfrom
HuberyJulianay wants to merge 3 commits intoparadigmxyz:mainfrom
Conversation
HuberyJulianay
requested review from
Rjected,
klkvr and
mattsse
as code owners
HuberyJulianay
changed the title
Collaborator
|
sorry, handled by #21225 the rocksdb/sf will be mostly handled by us, so feel free to pick any other issue from tracker, sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the inconsistency where StaticFilesArgs properly uses edge feature defaults but RocksDbArgs was always defaulting to false regardless of the feature flag.
Before this, if you compiled with --features edge, you'd still need to manually pass --rocksdb.tx-hash=true to get the actual edge behavior defined in StorageSettings::edge(). Now it just works.