feat(engine): add time_between_forkchoice_updated metric#21227
Merged
Rjected merged 2 commits intoparadigmxyz:mainfrom Jan 20, 2026
Merged
feat(engine): add time_between_forkchoice_updated metric#21227Rjected merged 2 commits intoparadigmxyz:mainfrom
Rjected merged 2 commits intoparadigmxyz:mainfrom
Conversation
livehardd
requested review from
Rjected,
fgimenez,
mattsse,
mediocregopher and
yongkangc
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #21159.
Noticed forkchoiceUpdated was missing the interval tracking that newPayload got. Added the same two histograms - time_between_forkchoice_updated for idle time and forkchoice_updated_interval for the full start-to-start interval.
Had to change update_response_metrics to &mut self to store the timestamps, same as NewPayloadStatusMetrics does.