fix(exex): prevent ExExManager deadlock when buffer clears after being full#21135
Merged
mattsse merged 3 commits intoparadigmxyz:mainfrom Jan 16, 2026
Merged
Conversation
dhyaniarun1993
changed the title
mattsse
approved these changes
Jan 16, 2026
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
very nice find, tysm
this should do it
Comment on lines
+540
to
+544
| // If the buffer was full and we made space, we need to wake up to accept new notifications | ||
| if buffer_full && this.buffer.len() < this.max_capacity { | ||
| debug!(target: "exex::manager", "Buffer has space again, waking up senders"); | ||
| cx.waker().wake_by_ref(); | ||
| } |
Collaborator
There was a problem hiding this comment.
right because we have
while this.buffer.len() < this.max_capacity {
in front of the poll loop -.-
mattsse
added
C-bug
meyer9
pushed a commit
to meyer9/reth
that referenced
this pull request
Jan 16, 2026
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a deadlock scenario in the
ExExManagerwhere the manager could stop processing new notifications permanently after its internal buffer filled up and subsequently cleared.Closes #19665