perf(db): Sort transaction hash/nums before inserting them#21096
Closed
mediocregopher wants to merge 1 commit intomainfrom
Closed
perf(db): Sort transaction hash/nums before inserting them#21096mediocregopher wants to merge 1 commit intomainfrom
mediocregopher wants to merge 1 commit intomainfrom
Conversation
mediocregopher
requested review from
Rjected,
mattsse,
shekhirin and
yongkangc
Member
Author
|
Going to rebase onto #20993 |
pepyakin
reviewed
Jan 15, 2026
| /// Puts multiple transaction hash number mappings from a pre-sorted slice. | ||
| /// | ||
| /// The entries MUST be pre-sorted by transaction hash for optimal B-tree database performance. | ||
| /// Uses `cursor.upsert()` which handles arbitrary insertion order and duplicates. |
Member
There was a problem hiding this comment.
I don't get it, why do we use upsert if we already require guarantee that the entries are presorted?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting prior to insertion helps with locality when inserting into MDBX. When we migrate this data to rocksdb later it will also be helpful for perf to have it pre-sorted.