feat(storage): RocksDB support for genesis init and tx lookup stage#21068
Closed
yongkangc wants to merge 1 commit intoyk/rocksdb-stage-utils-combinedfrom
Closed
feat(storage): RocksDB support for genesis init and tx lookup stage#21068yongkangc wants to merge 1 commit intoyk/rocksdb-stage-utils-combinedfrom
yongkangc wants to merge 1 commit intoyk/rocksdb-stage-utils-combinedfrom
Conversation
This was referenced Jan 14, 2026
yongkangc
force-pushed
the
yk/rocksdb-init-txlookup
branch
from
be4ffaf to
06b42b8
Compare
joshieDo
force-pushed
the
joshie/par-save-blocks-rocksdb
branch
2 times, most recently
from
fff917c to
d8a600c
Compare
This was referenced Jan 14, 2026
yongkangc
force-pushed
the
yk/rocksdb-init-txlookup
branch
2 times, most recently
from
b19bda6 to
ff75aa9
Compare
yongkangc
changed the base branch from
joshie/par-save-blocks-rocksdb
to
yk/rocksdb-either-writer-ext
yongkangc
changed the base branch from
yk/rocksdb-either-writer-ext
to
yk/rocksdb-index-history-stages
gakonst
reviewed
Jan 16, 2026
Member
gakonst
left a comment
gakonst
left a comment
There was a problem hiding this comment.
Code Review: PR #21068
CI Status
- ❌ 5 failures
Changes Summary
RocksDB support for genesis init and tx lookup stage.
Review Notes
This PR is downstream of the core RocksDB PRs. Will need full review once upstream PRs (#21063-#21066) pass CI.
Key check needed: Verify genesis init correctly initializes RocksDB tables and tx lookup stage properly routes writes.
Review by @tempo_ai
yongkangc
force-pushed
the
yk/rocksdb-index-history-stages
branch
from
126621c to
968c76f
Compare
yongkangc
force-pushed
the
yk/rocksdb-init-txlookup
branch
from
ff75aa9 to
b365f5f
Compare
yongkangc
force-pushed
the
yk/rocksdb-index-history-stages
branch
from
968c76f to
3c7fd84
Compare
Add RocksDB support for: - Genesis history initialization via EitherWriter - TransactionLookup stage unwind operations - RocksDB provider append_*_history_shard methods - Metrics for RocksDB write operations
yongkangc
force-pushed
the
yk/rocksdb-init-txlookup
branch
from
b365f5f to
a7edbcd
Compare
yongkangc
changed the base branch from
yk/rocksdb-index-history-stages
to
yk/rocksdb-stage-utils-combined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RocksDB support for genesis initialization and transaction lookup stage.
Changes
Testing
Genesis init and tx lookup verified.
PR Stack