Skip to content

docs(storage): fix typos in storage crates#20673

Merged
yongkangc merged 4 commits intoparadigmxyz:mainfrom
meetrick:reth/storage-fix_typo
Dec 30, 2025
Merged

docs(storage): fix typos in storage crates#20673
yongkangc merged 4 commits intoparadigmxyz:mainfrom
meetrick:reth/storage-fix_typo

Conversation

@meetrick
Copy link
Contributor

@meetrick meetrick commented Dec 29, 2025

Fix minor documentation typos in crates/storage:

  • nippy-jar/src/writer.rs: "If will" → "It will"
  • storage-api/src/state.rs: "all all" → "all"
  • db-api/src/cursor.rs: "DupSorted" → "DupSort"

- Fix "If will" → "It will" in nippy-jar
- Fix duplicate "all" in storage-api

Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 29, 2025

CodSpeed Performance Report

Merging #20673 will not alter performance

Comparing meetrick:reth/storage-fix_typo (840e962) with main (0f585f8)

Summary

✅ 118 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@meetrick
Copy link
Contributor Author

meetrick commented Dec 29, 2025

@joshieDo @shekhirin This CodSpeed Performance Report appears to be CI noise.

This PR only changes comments in crates/storage/ and has no relation to
crates/trie/common/benches/hashed_state.rs.

Could someone please re-run the benchmark or acknowledge this result?

  • Solved

@meetrick meetrick marked this pull request as draft December 29, 2025 22:31
@meetrick meetrick marked this pull request as ready for review December 29, 2025 22:31
Fix `DupSorted` to `DupSort` to match the actual trait name.

Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
@meetrick meetrick requested a review from rakita as a code owner December 30, 2025 00:36
@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Dec 30, 2025
@yongkangc yongkangc enabled auto-merge December 30, 2025 06:03
@yongkangc yongkangc self-assigned this Dec 30, 2025
@yongkangc yongkangc added the spelling Label for spelling, grammar, and typo fix PRs label Dec 30, 2025
@yongkangc yongkangc disabled auto-merge December 30, 2025 06:03
@yongkangc yongkangc enabled auto-merge December 30, 2025 06:07
@yongkangc yongkangc added this pull request to the merge queue Dec 30, 2025
Merged via the queue into paradigmxyz:main with commit 5053322 Dec 30, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Dec 30, 2025
@meetrick meetrick deleted the reth/storage-fix_typo branch December 30, 2025 06:28
gakonst added a commit that referenced this pull request Jan 19, 2026
Combined fixes from multiple closed PRs that were labeled 'spelling':

- [docs: add Ethereum section to table of contents and fix heading level](#21170)
- [docs(banlist): fix doc comments referencing ip instead of peer](#21044)
- [fix: correct comment references and remove duplicate in codecs derive](#20977)
- [fix: typos and grammatical errors in comments and docstrings](#20936)
- [fix(rpc): correct parameter name in MinerApi::set_gas_limit](#20926)
- [chore: remove pooled transaction clones](#20910)
- [docs: fix grammar in comments](#20909)
- [fix: typos in error messages and comments](#20908)
- [docs: fix broken Next Chapter link in reth-db crate docs](#20907)
- [chore(trie): fix typo in comment](#20870)
- [docs(storage): fix typos in storage crates](#20673)
gakonst added a commit that referenced this pull request Jan 19, 2026
Combined fixes from multiple closed PRs that were labeled 'spelling':

- [docs: add Ethereum section to table of contents and fix heading level](#21170)
- [docs(banlist): fix doc comments referencing ip instead of peer](#21044)
- [fix: correct comment references and remove duplicate in codecs derive](#20977)
- [fix: typos and grammatical errors in comments and docstrings](#20936)
- [fix(rpc): correct parameter name in MinerApi::set_gas_limit](#20926)
- [chore: remove pooled transaction clones](#20910)
- [docs: fix grammar in comments](#20909)
- [fix: typos in error messages and comments](#20908)
- [docs: fix broken Next Chapter link in reth-db crate docs](#20907)
- [chore(trie): fix typo in comment](#20870)
- [docs(storage): fix typos in storage crates](#20673)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spelling Label for spelling, grammar, and typo fix PRs

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants