feat: add engine_getBlobsV3 method#20451
Conversation
0xKarl98
requested review from
Rjected,
fgimenez,
gakonst,
klkvr,
mattsse and
yongkangc
as code owners
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this looks great already, only have a question re some additional code changes
| NoopNetwork::default(), | ||
| true, |
There was a problem hiding this comment.
why do we need this change
crates/node/builder/src/rpc.rs
Outdated
| let blobs_disabled = | ||
| ctx.config.txpool.disable_blobs_support || ctx.config.txpool.blobpool_max_count == 0; |
There was a problem hiding this comment.
don't think this is related to this pr?
There was a problem hiding this comment.
Because in the spec , it states as this :
Client software MUST return null if syncing or otherwise unable to generally serve blob pool data.
So i use this to identify if we are currently syncing or any other reasons that causes blob pool can't serve
There was a problem hiding this comment.
After think about it again , we can remove this blobs_disabled , just keep the judge of if syncing
|
|
||
| fn get_by_versioned_hashes_eip7594( |
There was a problem hiding this comment.
let's add some docs here about how this behaves
mattsse
added
C-enhancement
| // Spec requires returning `null` if syncing. | ||
| if (*self.inner.is_syncing)() { | ||
| return Ok(None) | ||
| } |
There was a problem hiding this comment.
ah I see, now this makes sense
2 participants
This closes issue #20415
cc @mattsse @klkvr