feat(node-core): make rpc server args customizable#20312
Merged
mattsse merged 7 commits intoparadigmxyz:mainfrom Dec 11, 2025
Merged
feat(node-core): make rpc server args customizable#20312mattsse merged 7 commits intoparadigmxyz:mainfrom
mattsse merged 7 commits intoparadigmxyz:mainfrom
Conversation
figtracer
requested review from
Rjected,
gakonst,
klkvr and
mattsse
as code owners
shekhirin
added
C-enhancement
Contributor
Author
on it |
figtracer
commented
Dec 11, 2025
| /// This is __not__ used for the authenticated engine-API RPC server, see | ||
| /// `--authrpc.jwtsecret`. | ||
| #[arg(long = "rpc.jwtsecret", value_name = "HEX", global = true, required = false)] | ||
| #[arg(long = "rpc.jwtsecret", value_name = "HEX", global = true, required = false, default_value = Resettable::from(DefaultRpcServerArgs::get_global().rpc_jwtsecret.as_ref().map(|v| format!("{:?}", v).into())))] |
Contributor
Author
There was a problem hiding this comment.
idk if using format! as a workaround can cause formatting problems
shekhirin
approved these changes
Dec 11, 2025
Member
shekhirin
left a comment
shekhirin
left a comment
There was a problem hiding this comment.
LGTM, just the lint needs fixing
mattsse
approved these changes
Dec 11, 2025
Vui-Chee
added a commit
to okx/reth
that referenced
this pull request
Dec 12, 2025
…number * upstream: (203 commits) feat(node-core): make rpc server args customizable (paradigmxyz#20312) feat: add `account_history_in_rocksdb` field to `StorageSettings` (paradigmxyz#20282) feat(engine): Add BAL stub methods to ExecutionPayload and BlockOrPayload (paradigmxyz#20311) docs: fix misleading links (paradigmxyz#20300) ci: add more sccache (paradigmxyz#20316) feat: bump alloy-evm (paradigmxyz#20314) feat: allow larger ws frames on client side (paradigmxyz#20307) docs: add architecture diagrams to ExEx documentation (paradigmxyz#20193) feat: add semaphore for blocking IO requests (paradigmxyz#20289) ci: scale down depot runners (paradigmxyz#20295) perf: fetch header directly (paradigmxyz#20294) docs(exex): fix DebugApi comment (paradigmxyz#20296) feat: add support for testing_ rpc namespace and testing_buildBlockV1 (paradigmxyz#20094) chore: update engine_getBlobs metric (paradigmxyz#20290) chore(optimism): move predeploy constant to op-alloy (paradigmxyz#20181) docs: fix stages order and add missing EraStage (paradigmxyz#20283) docs: improve map_add_ons method documentation (paradigmxyz#20248) feat: add `transaction_hash_numbers_in_rocksdb` field to `StorageSettings` (paradigmxyz#20209) docs: clarify network mode, tx gossip and NAT (paradigmxyz#20247) feat: add support for debug_getBadBlock (paradigmxyz#20177) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds #20305