Skip to content

feat(persistence): batch write hashed_state #19990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
duyquang6 wants to merge 3 commits into from
Closed

feat(persistence): batch write hashed_state #19990

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0dabbb8
perf: improve extend_sorted_vec & write batch for HashedPostState
duyquang6 Nov 26, 2025
e7eb205
chore: add unit-test
duyquang6 Nov 27, 2025
95c86c1
fix: comment
duyquang6 Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions crates/storage/provider/src/providers/database/provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,8 @@ impl<TX: DbTx + DbTxMut + 'static, N: NodeTypesForProvider> DatabaseProvider<TX,

debug!(target: "providers::db", block_count = %blocks.len(), "Writing blocks and execution data to storage");

let mut aggregated_hashed_post_state_sorted = HashedPostStateSorted::default();

// TODO: Do performant / batched writes for each type of object
// instead of a loop over all blocks,
// meaning:
Expand All @@ -337,13 +339,16 @@ impl<TX: DbTx + DbTxMut + 'static, N: NodeTypesForProvider> DatabaseProvider<TX,
// Must be written after blocks because of the receipt lookup.
self.write_state(&execution_output, OriginalValuesKnown::No)?;

// insert hashes and intermediate merkle nodes
self.write_hashed_state(&trie_data.hashed_state)?;
// aggregate hashed post states for batch insert
aggregated_hashed_post_state_sorted.extend_ref(&trie_data.hashed_state);

self.write_trie_changesets(block_number, &trie_data.trie_updates, None)?;
self.write_trie_updates_sorted(&trie_data.trie_updates)?;
}

// batch insert hash post states
self.write_hashed_state(&aggregated_hashed_post_state_sorted)?;

// update history indices
self.update_history_indices(first_number..=last_block_number)?;

Expand Down Expand Up @@ -1725,7 +1730,7 @@ impl<TX: DbTxMut + DbTx + 'static, N: NodeTypesForProvider> StateWriter
) -> ProviderResult<()> {
// Write storage changes
tracing::trace!("Writing storage changes");
let mut storages_cursor = self.tx_ref().cursor_dup_write::<tables::PlainStorageState>()?;
let mut storages_cursor = self.tx_ref().cursor_dup_read::<tables::PlainStorageState>()?;
let mut storage_changeset_cursor =
self.tx_ref().cursor_dup_write::<tables::StorageChangeSets>()?;
for (block_index, mut storage_changes) in reverts.storage.into_iter().enumerate() {
Expand Down
Loading