feat(flashblock): Enable eth_getTransactionByHash support for flashblock#19954
Merged
mattsse merged 5 commits intoparadigmxyz:mainfrom Nov 25, 2025
Merged
feat(flashblock): Enable eth_getTransactionByHash support for flashblock#19954mattsse merged 5 commits intoparadigmxyz:mainfrom
mattsse merged 5 commits intoparadigmxyz:mainfrom
Conversation
0x00101010
commented
Nov 25, 2025
| OpEthApiError: FromEvmError<N::Evm>, | ||
| Rpc: RpcConvert<Primitives = N::Primitives, Error = OpEthApiError>, | ||
| { | ||
| async fn transaction_by_hash( |
Contributor
Author
There was a problem hiding this comment.
Note: Steps 1 and 3 duplicate logic from the default trait implementation rather than extracting to a helper method. This keeps the override self-contained and avoids adding a helper method to the trait API that would only exist to support this one override.
Also we check flashblocks first before checking pool (in case people are using nodes with txpool gossip enabled to serve rpc requests)
0x00101010
commented
Nov 25, 2025
| async move { | ||
| // Try to find the transaction on disk | ||
| let mut resp = self | ||
| if let Some((tx, meta)) = self |
Contributor
Author
There was a problem hiding this comment.
Reworked the function a bit to avoid unnecessary nested loops and improve readability
0x00101010
commented
Nov 25, 2025
| .cloned(); | ||
|
|
||
| let meta = indexed_tx.meta(); | ||
| return Ok(Some(TransactionSource::Block { |
Contributor
Author
There was a problem hiding this comment.
Did not choose to add a new FlashBlock source type, current Block type seem to represent the situation well
0x00101010
requested review from
Rjected,
RomanHodulak,
fgimenez and
mattsse
as code owners
0x00101010
force-pushed
the
flashblock-get-tx-by-hash
branch
from
d28b3b1 to
de6f424
Compare
sieniven
pushed a commit
to okx/reth
that referenced
this pull request
Dec 10, 2025
…ock (paradigmxyz#19954) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Vui-Chee
added a commit
to okx/reth
that referenced
this pull request
Dec 11, 2025
* dev: chore: Update cargo deps (#65) feat(flashblock): Enable eth_getTransactionByHash support for flashblock (paradigmxyz#19954) feat(flashblocks): Cache recent flashblocks (paradigmxyz#19786) feat(flashblock): improve state root calculation condition (paradigmxyz#19667) feat(flashblocks): add metrics for current block and index (paradigmxyz#19712) refactor(flashblock): Move all flashblocks related data structure to op-alloy (paradigmxyz#19608) chore: add target: flashblock for all flashblock related traces (paradigmxyz#19656) feat(metrics): implement RAII-based block timing with Prometheus support (#60) Fix fmt (#62)
sieniven
pushed a commit
to okx/reth
that referenced
this pull request
Dec 11, 2025
…ock (paradigmxyz#19954) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
…ock (paradigmxyz/reth#19954) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
…ock (paradigmxyz/reth#19954) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable eth_getTransactionByHash support for flashblock, bring it at parity with existing support